-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fuzzer crash in parseDateTime() #53764
Fix fuzzer crash in parseDateTime() #53764
Conversation
This is an automated comment for commit 7f53471 with description of existing statuses. It's updated for the latest CI running
|
if (arguments.size() == 3) | ||
args.emplace_back(FunctionArgumentDescriptor{"timezone", &isString<IDataType>, nullptr, "String"}); | ||
FunctionArgumentDescriptors optional_args{ | ||
{"timezone", &isString<IDataType>, &isColumnConst, "const String"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we check here that it's not only const
but also has type String
? Or it' done somewhere else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
&isString<IDataType>
is doing exactly this check.
Backport #53764 to 23.5: Fix fuzzer crash in parseDateTime()
Backport #53764 to 23.6: Fix fuzzer crash in parseDateTime()
Backport #53764 to 23.7: Fix fuzzer crash in parseDateTime()
Fixes #53715
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix crash in SQL function parseDateTime() with non-const timezone argument